kyle
1ab0ed947c
- Update method line numbers in agent.md to match current codebase - Correct file sizes and line counts in the documentation table - Update TODO.md: mark line number and file size updates as completed - Move remaining tasks to Future Ideas section
2.3 KiB
2.3 KiB
nc_bot_webhooks — Pending Tasks
Debug Endpoint
- Re-enable admin auth requirement for
/debugendpoint (WebhookController.php) - Re-enable admin gate + update docs
README / Documentation Fixes
- Section 4: App password path — confirmed "Personal Settings → Security" is correct
- Section 4 (FIXED): Template hint
templates/adminSettings.php:11— confirmed correct path - Section 4: l10n string
lib/Settings/Admin.php:43— confirmed correct path - Section 5: "Administration → Additional settings" → confirmed correct for current NC
- Section 3: "Settings → Users" → confirmed correct for current NC
- Security table:
allow_local_address: truedescription — clarified wording - Image cleanup cron grep — already correct in README (
grep 'nc_bot_webhooks: purged') - Troubleshooting:
ncdiscordhookapp ID — not in README (only in agent.md, which is correct) - Payload Mapping:
mapPayloadtitle — confirmed bold formatting correct - Payload Mapping:
typeicon mapping — confirmed actual emojis listed - Home Assistant YAML:
messagevsbody—messageworks via fallback, no change needed - Version: bumped to 1.2.1 (info.xml + agent.md updated)
- NC max-version: docs say 33, info.xml says 35 — agent.md updated
Code Documentation Fixes
buildRichObjectdocs describe public link shares; code uses TYPE_ROOM sharespostToRoomdocs describe JSON body posting; code uses query paramsprependDisplayNamesignature — already documents all 3 params including$typeIcongetRooms()response schema missingtype,type_label,object_typesaveConfigdocs missingdisabled_roomsfieldensureBotParticipantsvisibility — already documented asprivatewith call contextgetBaseUrl()resolution incompletely documented- TalkService constructor params: docs say 8, actual 17
- TalkService.php size: docs say 1138 lines, actual 1904
- All line numbers in agent.md are stale
- File sizes table: multiple files have wrong line counts
Code Issues
- All line numbers in agent.md are stale
Future Ideas
- Room type filter
type IN (1,2,3)misses type 6 (and future types) — considertype >= 1or similar - Debug auto-disable timer (2-hour TTL) to prevent accidental prolonged exposure