kyle
1ab0ed947c
- Update method line numbers in agent.md to match current codebase - Correct file sizes and line counts in the documentation table - Update TODO.md: mark line number and file size updates as completed - Move remaining tasks to Future Ideas section
41 lines
2.3 KiB
Markdown
41 lines
2.3 KiB
Markdown
# nc_bot_webhooks — Pending Tasks
|
|
|
|
## Debug Endpoint
|
|
- [x] Re-enable admin auth requirement for `/debug` endpoint (WebhookController.php)
|
|
- [x] Re-enable admin gate + update docs
|
|
|
|
## README / Documentation Fixes
|
|
- [x] Section 4: App password path — confirmed "Personal Settings → Security" is correct
|
|
- [x] Section 4 (FIXED): Template hint `templates/adminSettings.php:11` — confirmed correct path
|
|
- [x] Section 4: l10n string `lib/Settings/Admin.php:43` — confirmed correct path
|
|
- [x] Section 5: "Administration → Additional settings" → confirmed correct for current NC
|
|
- [x] Section 3: "Settings → Users" → confirmed correct for current NC
|
|
- [x] Security table: `allow_local_address: true` description — clarified wording
|
|
- [x] Image cleanup cron grep — already correct in README (`grep 'nc_bot_webhooks: purged'`)
|
|
- [x] Troubleshooting: `ncdiscordhook` app ID — not in README (only in agent.md, which is correct)
|
|
- [x] Payload Mapping: `mapPayload` title — confirmed bold formatting correct
|
|
- [x] Payload Mapping: `type` icon mapping — confirmed actual emojis listed
|
|
- [x] Home Assistant YAML: `message` vs `body` — `message` works via fallback, no change needed
|
|
- [x] Version: bumped to 1.2.1 (info.xml + agent.md updated)
|
|
- [x] NC max-version: docs say 33, info.xml says 35 — agent.md updated
|
|
|
|
## Code Documentation Fixes
|
|
- [x] `buildRichObject` docs describe public link shares; code uses TYPE_ROOM shares
|
|
- [x] `postToRoom` docs describe JSON body posting; code uses query params
|
|
- [x] `prependDisplayName` signature — already documents all 3 params including `$typeIcon`
|
|
- [x] `getRooms()` response schema missing `type`, `type_label`, `object_type`
|
|
- [x] `saveConfig` docs missing `disabled_rooms` field
|
|
- [x] `ensureBotParticipants` visibility — already documented as `private` with call context
|
|
- [x] `getBaseUrl()` resolution incompletely documented
|
|
- [x] TalkService constructor params: docs say 8, actual 17
|
|
- [x] TalkService.php size: docs say 1138 lines, actual 1904
|
|
- [x] All line numbers in agent.md are stale
|
|
- [x] File sizes table: multiple files have wrong line counts
|
|
|
|
## Code Issues
|
|
- [x] All line numbers in agent.md are stale
|
|
|
|
## Future Ideas
|
|
- Room type filter `type IN (1,2,3)` misses type 6 (and future types) — consider `type >= 1` or similar
|
|
- Debug auto-disable timer (2-hour TTL) to prevent accidental prolonged exposure
|